Re: [pgAdmin4][RM#3298] Query tool shortcut issue

From: Victoria Henry <vhenry(at)pivotal(dot)io>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#3298] Query tool shortcut issue
Date: 2018-05-08 13:59:48
Message-ID: CANxYE3+5suV5SROfTW6vpazTYZAbCkbBcc2Ky3MfDApP7mjDDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Aditya,

The patch looks fine and the tests are passing.

Sincerely,

Victoria & Anthony

On Tue, May 8, 2018 at 8:22 AM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> PFA patch for query tool keyboard issue where arrow keys were not behaving
> as expected for execute options dropdown. Also, corrected couple of
> dropdown HTML codes.
>
> Request you to kindly review.
>
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Anthony Emengo 2018-05-08 16:03:53 Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Previous Message Aditya Toshniwal 2018-05-08 12:22:16 [pgAdmin4][RM#3298] Query tool shortcut issue