From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Load/Save file in query tool |
Date: | 2016-05-14 05:29:59 |
Message-ID: | CANxoLDe1GRMAXBh0XSgkddzxABeX-e=u+iZmE6jq1T0wiy3iOw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Surinder
On 13-May-2016 7:12 pm, "Surinder Kumar" <surinder(dot)kumar(at)enterprisedb(dot)com>
wrote:
>
> Hi,
>
> Please find updated patch
>
> Following are the review comments given by Akshay:
> 1. Save button shouldn't enable when data grid is loaded.
> 2. CodeMirror text area change event should only be enabled when query
tool is loaded.
I have tested the patch it is not working with Chrome Browser version 48.0
gives error "unexpected token =". I have check error comes in
file_manager.js line number 177. It is working fine with Firefox. Please
check and send the patch again.
>
>
> On Thu, May 12, 2016 at 1:23 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>> Hi,
>>
>> Please find attached patch for load/save file in query tool.
>> This patch is dependent on FileManager patch.
>>
>> Do review the patch and let me know for any comments.
>>
>> Thanks,
>> Surinder Kumar
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2016-05-14 09:59:31 | pgAdmin 4 commit: Load, and save the files in the Query Editor. |
Previous Message | Harshal Dhumal | 2016-05-13 20:33:42 | Re: [PATCH] Tables node (pgAdmin4) |