| From: | Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tables node (pgAdmin4) |
| Date: | 2016-05-13 20:33:42 |
| Message-ID: | CAFiP3vw5nx2Wdt9ci-MNRV+H+dO-x9KUSZtk16EZKjdox+KRxg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
PFA updated patches (version: 6) for table and it's child nodes.
--
*Harshal Dhumal*
*Software Engineer *
EenterpriseDB <http://www.enterprisedb.com>
On Fri, May 13, 2016 at 6:55 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Review Comments:
>
> - Please replace 'can not' with 'cannot' in all the validation messages.
> - PG 9.1+ Inheritance issue as below:
>
> CREATE TABLE public.table1
> (
> )
> (
> )
> INHERITS (a)
> WITH (
> OIDS = FALSE
> )
> TABLESPACE pg_default;
> ALTER TABLE public.table1
> OWNER to postgres;
>
>
> brackets are coming twice.
>
Fixed
>
> - Please maintain one line spacing between SQL queries In the SQL Tab.
>
TODO
> - Foreign Key Grid in Table css issue: Grid columns expands on the
> selection of the cell
>
Fixed
> - Check Constraint: Validated? option should be True by default
>
Not sure about this. I cross checked in pgadmin3.
> - pg 9.4: Exclude constraint does not render in SQL tab
>
Fixed
> - Missing Security validation
>
Fixed
> - Vacuum grid should not be editable in properties mode.
>
TODO (It's editable but one cannot save it on server from here as there is
no save button.)
> - Edit mode, Fill Factor can be allowed to be null.
>
TODO (This is generic issue in Integer and Numeric controls. This issue is
covered in this partial patch
<http://www.postgresql.org/message-id/CAFiP3vzvtqxJMpZeeaV4pd0p7CevcRRDfgDWuvu4cyHNThpJFQ@mail.gmail.com>
)
> - While dropping inheritance, related table columns drop SQL are also
> populated in the SQL Tab
>
> ALTER TABLE public."Tbl"
> NO INHERIT b;
> ALTER TABLE public."Tbl" DROP COLUMN id;
> ALTER TABLE public."Tbl" DROP COLUMN name;
>
>
Fixed
>
> And also render error while clicking on the save button.
>
> ERROR: syntax error at or near "["
> LINE 2: INHERIT [;
>
> ^
>
> Fixed
> - in a Reverse Engineering SQL tab, schema_name.tablename should be there,
> currently only table_name displays.
>
Fixed
> - Column SQL is showing below text with HTML
>
>
> <html><head></head><body>-- Column: id -- ALTER TABLE public.a DROIP
> COLUMN id; ALTER TABLE public.a ADD COLUMN id integer;</body></html>
>
>
I was not able to reproduce exact issue but still I have fixed other issue
which I found related to column SQL. Hopefully that will fix this issue as
well.
> - The column datatype dependency does not get cleared upon selection of
> another datatype.
>
For example, if I select numeric and gives the length and precision. After
> that I change the dat-type then, dependent fields should be get cleared.
>
Fixed.
>
> - The column datatype does not get displayed in the properties and edit
> mode if the length and precision are given while creating a column.
>
TODO ( I cannot fix this blindly as this might introduce another issue(s)
in column node. I will need Murtuza's help as he has worked on column node)
>
> - Statistics is showing null value even after having value.
>
Fixed
>
> - if the check constraints are not validated then put proper icon in tree
> and also it should be validated in edit mode.
>
Not reproducible.
>
> NOTE: I have not checked the Indexes, Triggers and Rules nodes as I do not
> have much knowledge about it.
>
>
> Thanks,
> Khushboo
>
> On Fri, May 13, 2016 at 5:24 PM, Harshal Dhumal <
> harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
>
>> Hi
>>
>> PFA attached patches for table and it's child nodes with python 2.7
>> compatibility.
>>
>>
| Attachment | Content-Type | Size |
|---|---|---|
| table_14_May_V6.patch.zip | application/zip | 84.0 KB |
| index_constraint_14_May_V6.patch.zip | application/zip | 13.1 KB |
| foreign_key_14_May_V6.patch.zip | application/zip | 16.1 KB |
| check_constraint_14_May_V6.patch.zip | application/zip | 9.4 KB |
| exclusion_constraint_14_May_V6.patch.zip | application/zip | 14.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2016-05-14 05:29:59 | Re: [pgAdmin4][Patch]: Load/Save file in query tool |
| Previous Message | Ashesh Vashi | 2016-05-13 20:11:56 | Re: [pgAdmin4][Patch]: Pause/Resume replay of WAL functionality |