| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Load/Save file in query tool |
| Date: | 2016-05-13 13:41:42 |
| Message-ID: | CAM5-9D_Bcz=cCb+fhiOOTECXKnzzYHwJq=xAaqo-oWcaB5mFwg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
Please find updated patch
Following are the review comments given by Akshay:
1. Save button shouldn't enable when data grid is loaded.
2. CodeMirror text area change event should only be enabled when query tool
is loaded.
On Thu, May 12, 2016 at 1:23 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch for load/save file in query tool.
> This patch is dependent on FileManager patch.
>
> Do review the patch and let me know for any comments.
>
> Thanks,
> Surinder Kumar
>
| Attachment | Content-Type | Size |
|---|---|---|
| load_save_in_query_tool_v1.patch | application/octet-stream | 11.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-05-13 13:44:16 | pgAdmin 4 commit: Add some initial dialog docs. |
| Previous Message | Khushboo Vashi | 2016-05-13 13:25:33 | Re: [PATCH] Tables node (pgAdmin4) |