Re: variable scope issue in server js [pgadmin4]

On Thu, May 12, 2016 at 7:47 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Murtuza hasn't fixed it in all places. He missed in following tow functions
>
> connect_server and disconnect_server
>
>
> Thanks - Committed

>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com>
>
> On Thu, May 12, 2016 at 7:38 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi
>>
>> On Thu, May 12, 2016 at 5:05 PM, Harshal Dhumal <harshal.dhumal@
>> enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>>
>>> PFA patch for server.js. Replaced ";" (semicolon) with "," (coma) in
>>> variable declaration.
>>>
>>> Issue: This was changing scope of all the variables declared after ";"
>>> (semicolon) from *local* to *global* and therefore affecting all other *local
>>> variables *with same name at different place in same file.
>>>
>>
>> Thanks- it is already being committed with the patch for "Named
>> Restore Point" send by Murtuza.
>>
>>>
>>>
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB <http://www.enterprisedb.com>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*