Re: variable scope issue in server js [pgadmin4]

From: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: variable scope issue in server js [pgadmin4]
Date: 2016-05-12 14:17:08
Message-ID: CAFiP3vze-0c02Ed5fwJkTNkAmpaPA_4CGH0B06R-6khSasmbAA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

Murtuza hasn't fixed it in all places. He missed in following tow functions

connect_server and disconnect_server

--
*Harshal Dhumal*
*Software Engineer *

EenterpriseDB <http://www.enterprisedb.com>

On Thu, May 12, 2016 at 7:38 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi
>
> On Thu, May 12, 2016 at 5:05 PM, Harshal Dhumal <harshal.dhumal@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>>
>> PFA patch for server.js. Replaced ";" (semicolon) with "," (coma) in
>> variable declaration.
>>
>> Issue: This was changing scope of all the variables declared after ";"
>> (semicolon) from *local* to *global* and therefore affecting all other *local
>> variables *with same name at different place in same file.
>>
>
> Thanks- it is already being committed with the patch for "Named Restore
> Point" send by Murtuza.
>
>>
>>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB <http://www.enterprisedb.com>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-05-12 14:22:44 PATCH: CREATE Script Initial patch (pgAdmin4)
Previous Message Akshay Joshi 2016-05-12 14:08:25 Re: variable scope issue in server js [pgadmin4]