Re: variable scope issue in server js [pgadmin4]

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: variable scope issue in server js [pgadmin4]
Date: 2016-05-12 14:08:25
Message-ID: CANxoLDdZDCOavAmQXVoYpHwLopGhKfisbOaWn25+XWy6mY7Ndw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, May 12, 2016 at 5:05 PM, Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb
.com> wrote:

> Hi,
>
>
> PFA patch for server.js. Replaced ";" (semicolon) with "," (coma) in
> variable declaration.
>
> Issue: This was changing scope of all the variables declared after ";"
> (semicolon) from *local* to *global* and therefore affecting all other *local
> variables *with same name at different place in same file.
>

Thanks- it is already being committed with the patch for "Named Restore
Point" send by Murtuza.

>
>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http://www.enterprisedb.com>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2016-05-12 14:17:08 Re: variable scope issue in server js [pgadmin4]
Previous Message Khushboo Vashi 2016-05-12 13:25:02 Re: [PATCH] Tables node (pgAdmin4)