Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi Anthony

Thanks for updated patch, it is working fine on my machine. I have tested
it couple of times.

On Sat, May 12, 2018 at 3:48 AM, Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:

>
> I completely apologize.
>
> With regards to pgadmin.feature_tests.xss_checks_file_manager_test.
> CheckFileManagerFeatureTest My original fix was working for Firefox but
> when I tried to adjust it for Chrome, it doesn’t seem to be working
> reliably for both browsers. What I was able to get working reliably for
> today was to do a check on what browser was running and run the appropriate
> wait function (Chrome doesn’t need it). The wait is explicitly for the
> element to go stale and then un-stale once more.
>
> [image: Screen Shot 2018-05-11 at 5.55.54 PM.png]
>
> [image: Screen Shot 2018-05-11 at 5.55.40 PM.png]
>
> For what it’s worth however, I have not seen any failures today with
> pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest,
> on Firefox.I'm running on an Mac OSX system.
> ​
> Cheers and good weekend! 😀
>
>>

--
*Akshay Joshi*

*Sr. Software Architect *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*