Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: Anthony Emengo <aemengo(at)pivotal(dot)io>, Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Date: 2018-05-14 12:15:05
Message-ID: CA+OCxoyGHCPMG-5NeVCkU51y1AtZYTwrdoVFWM-0WDCz-evxyw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, May 14, 2018 at 7:29 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi Anthony
>
> Thanks for updated patch, it is working fine on my machine. I have tested
> it couple of times.
>
>
I've tested it a couple of times and still see the pgDataType failure. I've
attached the screenshot; I have to wonder why that test is throwing a
syntax error at all as it's only supposed to test that we display different
datatypes correctly. Looking further, it seems that it's trying to execute
a badly corrupted query. How did it get that way? Do we need to clear the
CodeMirror box before trying to replace the query?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
image/png 40.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2018-05-14 12:31:05 pgAdmin 4 commit: Initial version of the new tree implementation.
Previous Message Dave Page 2018-05-14 09:29:56 Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree