From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin 4 commit: Initial version of the new tree implementation. |
Date: | 2018-05-14 12:31:05 |
Message-ID: | E1fICd7-00028i-9C@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Initial version of the new tree implementation.
This is the first version of our Tree implementation. At this point is a
very simple tree without no abstractions and with code that eventually
is not very performant, but this is only the first iteration and we are
trying to follow the 'Last Responsible Moment Principle' [1].
Implemention details:
- Creation of PGBrowser.treeMenu
- Initial version of the Tree Adaptor 'pgadmin/static/js/tree/tree.js'
- TreeFake test double that can replace the Tree for testing purposes
- Tests, As an interesting asside because Fake’s need to behave like
the real object you will noticed that there are tests for this type
of double and they the same as of the real object.
Patched by: Victoria && Joao
Reviewed by: Khushboo & Ashesh
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc4d16eb8333ff0e611146e1cb83443b7da55eba
Author: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
Modified Files
--------------
web/pgadmin/browser/static/js/browser.js | 4 +
web/pgadmin/static/js/tree/tree.js | 212 ++++++++++++++
web/regression/javascript/tree/tree_fake.js | 69 +++++
web/regression/javascript/tree/tree_spec.js | 420 ++++++++++++++++++++++++++++
4 files changed, 705 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2018-05-14 12:38:46 | Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree |
Previous Message | Dave Page | 2018-05-14 12:15:05 | Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox |