| From: | Anthony Emengo <aemengo(at)pivotal(dot)io> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox |
| Date: | 2018-05-11 22:18:01 |
| Message-ID: | CAG8BBZObXfHXnn+DoVCqv28ztDc9V4cP=1=s_iu3OOcZ+27c2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
I completely apologize.
With regards to
pgadmin.feature_tests.xss_checks_file_manager_test.CheckFileManagerFeatureTest
My original fix was working for Firefox but when I tried to adjust it for
Chrome, it doesn’t seem to be working reliably for both browsers. What I
was able to get working reliably for today was to do a check on what
browser was running and run the appropriate wait function (Chrome doesn’t
need it). The wait is explicitly for the element to go stale and then
un-stale once more.
[image: Screen Shot 2018-05-11 at 5.55.54 PM.png]
[image: Screen Shot 2018-05-11 at 5.55.40 PM.png]
For what it’s worth however, I have not seen any failures today with
pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest, on
Firefox.I'm running on an Mac OSX system.
Cheers and good weekend! 😀
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM_3270_v11.patch | application/octet-stream | 10.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2018-05-11 23:10:49 | Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree |
| Previous Message | Joao De Almeida Pereira | 2018-05-11 21:27:25 | Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree |