Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
Date: 2022-01-21 06:22:32
Message-ID: CANxoLDcTS4VFmvrTbNriT3DS6ZwL0fUE5K6VLUBEgZtmxMgvSA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, the patch applied.

On Thu, Jan 20, 2022 at 3:18 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached patch which fixes all comments given below.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Yogesh
>>
>> Following are the review comments:
>>
>> - Increase the height of the dialog to avoid the scroll bars. Check
>> the height of the backup dialog.
>> - The 'OK' button should be disabled and the validation message
>> 'Please provide a file name.' should be shown the first time when the
>> dialog is opened. Check backup dialog
>> - The help button should be enabled and check it refers to the
>> appropriate page.
>> - Update the documentation and screenshots.
>>
>>
>> On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the patch which port import/export data dialogue to react.
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2022-01-21 12:02:54 [pgAdmin]: Remove "Move objects to..." option from tablespaces sub-node
Previous Message Akshay Joshi 2022-01-21 06:19:15 pgAdmin 4 commit: Port Import/Export dialog to React. Fixes #7017.