From: | Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com> |
---|---|
To: | |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React. |
Date: | 2022-01-20 09:12:13 |
Message-ID: | CAMa=N=Pp89zQOTavVQUSoA5VYsU2dmd=wBP5Sw4RLF=dCU_7nQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
Please find the attached patch which fixes all comments given below.
Thanks,
Yogesh Mahajan
EnterpriseDB
On Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Yogesh
>
> Following are the review comments:
>
> - Increase the height of the dialog to avoid the scroll bars. Check
> the height of the backup dialog.
> - The 'OK' button should be disabled and the validation message
> 'Please provide a file name.' should be shown the first time when the
> dialog is opened. Check backup dialog
> - The help button should be enabled and check it refers to the
> appropriate page.
> - Update the documentation and screenshots.
>
>
> On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <
> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the patch which port import/export data dialogue to react.
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachment | Content-Type | Size |
---|---|---|
RM_7017_v2.patch | application/octet-stream | 1.5 MB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2022-01-20 11:28:43 | pgAdmin 4 commit: Fixed code smell reported by SonarQube. |
Previous Message | Aditya Toshniwal | 2022-01-20 05:00:06 | Re: [pgAdmin][RM7016]: Port Dependent, dependencies, statistics panel to React. |