| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React. |
| Date: | 2022-01-19 14:17:24 |
| Message-ID: | CANxoLDfTDN+f8G4Ctmb2zy4LCdkPXv96Ta-aEGzS71v1JJXNRA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Yogesh
Following are the review comments:
- Increase the height of the dialog to avoid the scroll bars. Check the
height of the backup dialog.
- The 'OK' button should be disabled and the validation message 'Please
provide a file name.' should be shown the first time when the dialog is
opened. Check backup dialog
- The help button should be enabled and check it refers to the
appropriate page.
- Update the documentation and screenshots.
On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the patch which port import/export data dialogue to react.
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2022-01-19 14:34:42 | pgAdmin 4 commit: Fixed an issue where connections keep open to (closed |
| Previous Message | Pradip Parkale | 2022-01-19 12:06:20 | Re: [pgAdmin][RM7016]: Port Dependent, dependencies, statistics panel to React. |