Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.

From: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
Date: 2022-01-27 07:54:02
Message-ID: CAMa=N=NqKQt4MWaK42FHuCCyxDLbN3J8hXNtrtUJPpB8FG=-aw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Team,

Please find the attached patch which fixes the issue of duplicate values
shown in Column>Columns to Import/Export dropdown when a value(values) is
unselected.

Thanks,
Yogesh Mahajan
EnterpriseDB

On Fri, Jan 21, 2022 at 11:52 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, the patch applied.
>
> On Thu, Jan 20, 2022 at 3:18 PM Yogesh Mahajan <
> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch which fixes all comments given below.
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Yogesh
>>>
>>> Following are the review comments:
>>>
>>> - Increase the height of the dialog to avoid the scroll bars. Check
>>> the height of the backup dialog.
>>> - The 'OK' button should be disabled and the validation message
>>> 'Please provide a file name.' should be shown the first time when the
>>> dialog is opened. Check backup dialog
>>> - The help button should be enabled and check it refers to the
>>> appropriate page.
>>> - Update the documentation and screenshots.
>>>
>>>
>>> On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <
>>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the patch which port import/export data dialogue to react.
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> EnterpriseDB
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

Attachment Content-Type Size
RM_7017_v2.patch application/octet-stream 859 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2022-01-27 10:01:14 [pgAdmin4][Patch]: SonarQube Fixes
Previous Message Akshay Joshi 2022-01-27 06:41:53 Re: Feature #7109 - Directory Sizes Seem Incorrect While Selecting Binary Path