Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
Date: 2022-01-27 11:53:00
Message-ID: CANxoLDcTK9AjGtSPUnEQe1xcLdMshfenGSHps6cyxeFtUV+wdg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, the patch applied.

On Thu, Jan 27, 2022 at 1:24 PM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hello Team,
>
> Please find the attached patch which fixes the issue of duplicate values
> shown in Column>Columns to Import/Export dropdown when a value(values) is
> unselected.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
>
> On Fri, Jan 21, 2022 at 11:52 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Thu, Jan 20, 2022 at 3:18 PM Yogesh Mahajan <
>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch which fixes all comments given below.
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>>
>>> On Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Yogesh
>>>>
>>>> Following are the review comments:
>>>>
>>>> - Increase the height of the dialog to avoid the scroll bars. Check
>>>> the height of the backup dialog.
>>>> - The 'OK' button should be disabled and the validation message
>>>> 'Please provide a file name.' should be shown the first time when the
>>>> dialog is opened. Check backup dialog
>>>> - The help button should be enabled and check it refers to the
>>>> appropriate page.
>>>> - Update the documentation and screenshots.
>>>>
>>>>
>>>> On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <
>>>> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find the patch which port import/export data dialogue to react.
>>>>> Thanks,
>>>>> Yogesh Mahajan
>>>>> EnterpriseDB
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Principal Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2022-01-27 13:36:27 [pgAdmin][RM-7126]: F2 Function key removes browser panel contents
Previous Message Akshay Joshi 2022-01-27 11:52:45 Re: [pgAdmin4][Patch]: SonarQube Fixes