| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2 |
| Date: | 2018-09-10 13:03:56 |
| Message-ID: | CANxoLDcT6Lk7wx6QJHANMyjCOhxp2LucV3xOXAKB9CB_-pVg6w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Mon, Sep 10, 2018 at 6:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Mon, Sep 10, 2018 at 12:50 PM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the RM #3630 Autocomplete broken in v3.3
>> release, works in v3.2. Actual issue is due to merge the pgcli code, we
>> only consider "pg_catalog and public" schema's which I have fixed.
>>
>
> Can you add a unit/API test for this please (ideally not another feature
> test, as we already have some for autocomplete)?
>
We are waiting for pytest to be introduce in pgAdmin4, pgcli have API
test written in pytest.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2018-09-10 13:05:47 | Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features |
| Previous Message | Dave Page | 2018-09-10 12:51:57 | Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2 |