Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2
Date: 2018-09-10 12:51:57
Message-ID: CA+OCxoyUh=NinZVy2DavpgsETrWZZz8zmVywH8sjA8ToNEqwPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Mon, Sep 10, 2018 at 12:50 PM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the RM #3630 Autocomplete broken in v3.3
> release, works in v3.2. Actual issue is due to merge the pgcli code, we
> only consider "pg_catalog and public" schema's which I have fixed.
>

Can you add a unit/API test for this please (ideally not another feature
test, as we already have some for autocomplete)?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-09-10 13:03:56 Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2
Previous Message Dave Page 2018-09-10 12:39:21 Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features