Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

On Mon, Sep 10, 2018 at 2:03 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

>
>
> On Mon, Sep 10, 2018 at 6:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Mon, Sep 10, 2018 at 12:50 PM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix the RM #3630 Autocomplete broken in v3.3
>>> release, works in v3.2. Actual issue is due to merge the pgcli code, we
>>> only consider "pg_catalog and public" schema's which I have fixed.
>>>
>>
>> Can you add a unit/API test for this please (ideally not another feature
>> test, as we already have some for autocomplete)?
>>
>
> We are waiting for pytest to be introduce in pgAdmin4, pgcli have API
> test written in pytest.
>

That could be a very long wait. It seems unlikely that will proceed.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company