Re: Damage control for planner's get_actual_variable_endpoint() runaway

From: Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Damage control for planner's get_actual_variable_endpoint() runaway
Date: 2022-11-22 16:17:34
Message-ID: CANbhV-H34VhsvdOnneWv7TrOc3woPKgjP6skLSK4yJqhP7RGaQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 21 Nov 2022 at 20:55, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Nov 21, 2022 at 1:17 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On November 21, 2022 9:37:34 AM PST, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > >On Mon, Nov 21, 2022 at 12:30 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > >> This can't quite be right - isn't this only applying the limit if we found a
> > >> visible tuple?
> > >
> > >It doesn't look that way to me, but perhaps I'm just too dense to see
> > >the problem?
> >
> > The earlier version didn't have the issue, but the latest seems to only limit after a visible tuple has been found. Note the continue; when fetching a heap tuple fails.
>
> Oh, that line was removed in Simon's patch but not in Jakub's version,
> I guess. Jakub's version also leaves out the last_block = block line
> which seems pretty critical.

New patch version reporting for duty, sir. Please take it from here!

--
Simon Riggs http://www.EnterpriseDB.com/

Attachment Content-Type Size
0001-Damage-control-for-planner-s-get_actual_variable_end.v3.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-11-22 16:28:02 Re: Slow standby snapshot
Previous Message walther 2022-11-22 16:11:11 Re: fixing CREATEROLE