Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> writes:
> New patch version reporting for duty, sir. Please take it from here!
Why the CHECK_FOR_INTERRUPTS? I'd supposed that there's going to be
one somewhere down inside the index or heap access --- do you have
reason to think there isn't?
Is it appropriate to count distinct pages, rather than just the
number of times we have to visit a heap tuple? That seems to
complicate the logic a good deal, and I'm not sure it's buying
much, especially since (as you noted) it's imprecise anyway.
regards, tom lane