| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Damage control for planner's get_actual_variable_endpoint() runaway |
| Date: | 2022-11-21 20:55:20 |
| Message-ID: | CA+Tgmobn59GXb28h5Yj8=98xJcTMZgsMoffONXA6t-yuHXdEwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 21, 2022 at 1:17 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On November 21, 2022 9:37:34 AM PST, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >On Mon, Nov 21, 2022 at 12:30 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> This can't quite be right - isn't this only applying the limit if we found a
> >> visible tuple?
> >
> >It doesn't look that way to me, but perhaps I'm just too dense to see
> >the problem?
>
> The earlier version didn't have the issue, but the latest seems to only limit after a visible tuple has been found. Note the continue; when fetching a heap tuple fails.
Oh, that line was removed in Simon's patch but not in Jakub's version,
I guess. Jakub's version also leaves out the last_block = block line
which seems pretty critical.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ted Toth | 2022-11-21 20:57:21 | [PATCH] Add <<none>> support to sepgsql_restorecon |
| Previous Message | Andres Freund | 2022-11-21 20:52:02 | Re: [BUG] FailedAssertion in SnapBuildPurgeOlderTxn |