Re: Git-master regression failure

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Svenne Krap <svenne(dot)lists(at)krap(dot)dk>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Git-master regression failure
Date: 2013-06-19 21:50:07
Message-ID: CAMkU=1zTNqsuJwy=F3YqOrH3CtvVtfiVf3VGNcBLv9xgt4oB_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 19, 2013 at 8:41 AM, Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:

> Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > On 6/19/13 9:18 AM, Kevin Grittner wrote:
>
> >> Does anyone object to the attached change, so that regression tests
> >> pass when run in a Danish locale? I think it should be
> >> back-patched to 9.2, where the test was introduced.
> >
> > Yes, that should be fixed. I wouldn't put in the comment, though. A
> > few releases ago, I fixed a number of other "Danish" issues, so adding
> > this comment would give the impression that this the only place.
>
> OK, pushed without the comment.
>

I had started this and let it run overnight:

for LANG in `locale -a`; do make check >& /dev/null ; echo $? $LANG; done

Of the 735 language/locales/encodings, I got 93 failures. After your
commit I re-tested just the failures, and it fixed 25 of them.

Of the ones I looked at, most of the problems are in create_index, some in
matview as well.

Lithuanian has Y coming between I and J. Estonian has Z between S and T.
Norwegian seems to treat V and W as being equal except to break
suffix-ties.

Is there an infrastructure to use a different expected file depending on
the LANG used?

Cheers,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2013-06-19 22:01:44 Re: Vacuum/visibility is busted
Previous Message Stephen Frost 2013-06-19 21:20:21 Re: Implementing incremental backup