Re: Git-master regression failure

Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>> On 6/19/13 9:18 AM, Kevin Grittner wrote:
>>
>>
>>>> Does anyone object to the attached change, so that regression tests
>>>> pass when run in a Danish locale?  I think it should be
>>>> back-patched to 9.2, where the test was introduced.
>>>
>>> Yes, that should be fixed.  I wouldn't put in the comment, though.  A
>>> few releases ago, I fixed a number of other "Danish" issues, so adding
>>> this comment would give the impression that this the only place.
>>
>> OK, pushed without the comment.
>
> I had started this and let it run overnight:
>
> for LANG in `locale -a`; do make check >& /dev/null ; echo $? $LANG; done
>
> Of the 735 language/locales/encodings, I got 93 failures.

Ouch!

> After your commit I re-tested just the failures, and it fixed 25
> of them.

That's more than I would have guessed.  Cool.

> Of the ones I looked at, most of the problems are in
> create_index, some in matview as well.

So of the 68 remaining locales which fail, most are due to a couple
scripts.

> Lithuanian has Y coming between I and J.
> Estonian has Z between S and T.
> Norwegian seems to treat V and W as being equal except to break suffix-ties.

> Is there an infrastructure to use a different expected file
> depending on the LANG used?

Well, any one test can have alternative "expected" scripts; but in
previous discussions we decided that that facility should not be
used for locale issues.  It would tend to get into multiplicative
permutations with other reasons to have alternatives.  What we have
done is to try to create tests that don't hit those edge conditions
when we know of them.

Could you share your detailed information on the remaining failures?

--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company