From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dave(dot)page(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Materialized View Patch File |
Date: | 2013-07-18 04:58:39 |
Message-ID: | CAMcbDBHnm0vSn7BkA1u9MwYe+frCEFkmk-+uxHF6MPYvwpToSQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
Please find the updated patch with modification in query.
Thanks,
Neel Patel
On Wed, Jul 17, 2013 at 5:15 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>wrote:
> On Wed, Jul 17, 2013 at 12:23 PM, Neel Patel
> <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > Just want to know.
> >
> > Now we are passing GetName() to qtDbString() and to form the complete
> query
> > we need to use qtDbString() to compare the string.
> >
> > We have added below string.
> >
> > wxString sql = wxT("SELECT count(*) FROM pg_matviews WHERE matviewname =
> ")
> > + qtDbString(this->GetName()) + wxT(" AND schemaname = ") +
> > qtDbString(this->GetSchema()->GetName());
> >
> > Is it correct ?
>
> I'd expect you to be using GetQuotedIdentifier() there. For a view and
> schema, the identifier is the name anyway.
>
>
> --
> Dave Page
> Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
Attachment | Content-Type | Size |
---|---|---|
MaterializedView_Bug_Fix_V2.patch | application/octet-stream | 778 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2013-07-18 12:24:01 | Re: Materialized View Patch File |
Previous Message | Dinesh Kumar | 2013-07-17 17:09:22 | Re: pgAdmin bug - SQL creation for foreign keys |