Re: Materialized View Patch File

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Materialized View Patch File
Date: 2013-07-17 11:45:34
Message-ID: CA+OCxozavBu2c6cWQrnTgx+Wq7uL462RYGyU_3viP8JY-GjLxA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Jul 17, 2013 at 12:23 PM, Neel Patel
<neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Just want to know.
>
> Now we are passing GetName() to qtDbString() and to form the complete query
> we need to use qtDbString() to compare the string.
>
> We have added below string.
>
> wxString sql = wxT("SELECT count(*) FROM pg_matviews WHERE matviewname = ")
> + qtDbString(this->GetName()) + wxT(" AND schemaname = ") +
> qtDbString(this->GetSchema()->GetName());
>
> Is it correct ?

I'd expect you to be using GetQuotedIdentifier() there. For a view and
schema, the identifier is the name anyway.

--
Dave Page
Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Javier Urbano Contreras 2013-07-17 14:59:18 comparison schema/data
Previous Message Neel Patel 2013-07-17 11:23:38 Re: Materialized View Patch File