Re: pgAdmin bug - SQL creation for foreign keys

From: Dinesh Kumar <dinesh(dot)kumar(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Jakub Trmota <jakub(at)trmota(dot)cz>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin bug - SQL creation for foreign keys
Date: 2013-07-17 17:09:22
Message-ID: CAKWsr7hgrYREBVP1UoG7oTHr10c_AJgG=DfyYShoJBRqx9TLrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Further to my understanding, we don't any option available to deal
untranslated strings in XRC files. Hence, i have reset the label text with
the keywords. And also i have found this case with some other dialogue
boxes, and adding fix for those also.

Please find the attached patch for the same, and let me know your inputs.

Thanks in advance.

Dinesh

--
*Dinesh Kumar*
Software Engineer

Ph: +918087463317
Skype ID: dinesh.kumar432
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community> and
more <http://www.enterprisedb.com/resources-community>

On Tue, Jul 16, 2013 at 1:05 PM, Dinesh Kumar <dinesh(dot)kumar(at)enterprisedb(dot)com
> wrote:

> Hi Dave,
>
> On Mon, Jul 15, 2013 at 6:55 PM, Dinesh Kumar <
>> dinesh(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> I am able to re-produce the reported issue and with the create new role
>>> dialogue box. Please find the attached patch for these reported cases.
>>>
>>
>> This fix seems reasonable if we want the keywords to be translated in the
>> UI, but I don't think we do, because they are keywords not natural
>> language. Can we just prevent them being translated in the first place? If
>> they're in the XRC file, that may require us to reset the labels to
>> un-translated strings in code.
>>
>>
> Thanks Dave. Let me send you new patch with this suggested approach.
>
>
> Dinesh
>
> --
> *Dinesh Kumar*
> Software Engineer
>
> Ph: +918087463317
> Skype ID: dinesh.kumar432
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community> and
> more <http://www.enterprisedb.com/resources-community>
>

Attachment Content-Type Size
Dialogue_Items_Locale_Issue.patch application/octet-stream 3.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2013-07-18 04:58:39 Re: Materialized View Patch File
Previous Message Javier Urbano Contreras 2013-07-17 14:59:18 comparison schema/data