| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic() |
| Date: | 2025-02-19 02:30:24 |
| Message-ID: | CAMbWs4-XS3j-ZFqNs=hJhWLLSrZMitA=GD2EwNYY5ebX-oYijQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 19, 2025 at 9:58 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Wed, Feb 19, 2025 at 9:44 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > On Wed, Feb 19, 2025 at 09:36:35AM +0900, Richard Guo wrote:
> > > I plan to push this shortly. This is arguably a bug, but it hasn't
> > > caused any real issues, and nobody has complained about it until now,
> > > so I don't think it needs to be back-patched. Any thoughts?
> >
> > I can see a point in doing a backpatch to keep the code consistent
> > across branches, and this avoids incorrect access patterns when
> > copy-pasting this code.
>
> Hmm, fair point. I will backpatch-through 13.
Done.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-02-19 02:30:45 | Re: Why does exec_simple_query requires 2 snapshots |
| Previous Message | Dean Rasheed | 2025-02-19 01:42:38 | Re: Virtual generated columns |