Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic()

From: Tender Wang <tndrwang(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic()
Date: 2025-02-19 02:47:31
Message-ID: CAHewXNk6Dq3F7tgAqdjHQz3ZoKyGSAb+sOe4XGOys5Z=e1NYWA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Richard Guo <guofenglinux(at)gmail(dot)com> 于2025年2月19日周三 10:30写道:

> On Wed, Feb 19, 2025 at 9:58 AM Richard Guo <guofenglinux(at)gmail(dot)com>
> wrote:
> > On Wed, Feb 19, 2025 at 9:44 AM Michael Paquier <michael(at)paquier(dot)xyz>
> wrote:
> > > On Wed, Feb 19, 2025 at 09:36:35AM +0900, Richard Guo wrote:
> > > > I plan to push this shortly. This is arguably a bug, but it hasn't
> > > > caused any real issues, and nobody has complained about it until now,
> > > > so I don't think it needs to be back-patched. Any thoughts?
> > >
> > > I can see a point in doing a backpatch to keep the code consistent
> > > across branches, and this avoids incorrect access patterns when
> > > copy-pasting this code.
> >
> > Hmm, fair point. I will backpatch-through 13.
>
> Done.
>

Thanks for pushing.

--
Thanks,
Tender Wang

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2025-02-19 02:57:34 RE: ReplicationSlotRelease() crashes when the instance is in the single user mode
Previous Message Andres Freund 2025-02-19 02:35:56 Re: GetRelationPath() vs critical sections