Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic()

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tender Wang <tndrwang(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unsafe access BufferDescriptors array in BufferGetLSNAtomic()
Date: 2025-02-19 00:58:02
Message-ID: CAMbWs48Vg+GzV+_fc+gqcoWQuMye9rXyWp=7R=ywLGusHcG58w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 19, 2025 at 9:44 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Feb 19, 2025 at 09:36:35AM +0900, Richard Guo wrote:
> > I plan to push this shortly. This is arguably a bug, but it hasn't
> > caused any real issues, and nobody has complained about it until now,
> > so I don't think it needs to be back-patched. Any thoughts?
>
> I can see a point in doing a backpatch to keep the code consistent
> across branches, and this avoids incorrect access patterns when
> copy-pasting this code.

Hmm, fair point. I will backpatch-through 13.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenhui qiu 2025-02-19 01:07:43 Re: [Feature Request] INSERT FROZEN to Optimize Large Cold Data Imports and Migrations
Previous Message Noah Misch 2025-02-19 00:57:47 Re: Issues with 2PC at recovery: CLOG lookups and GlobalTransactionData