Re: duplicated comments on get_relation_constraints

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: duplicated comments on get_relation_constraints
Date: 2025-03-28 10:19:04
Message-ID: CAMbWs4-BkYaBDViv82VRC3+9ppB1AZiqutpUo4sHNw0UsGAr2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 28, 2025 at 4:53 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> On Fri, 28 Mar 2025 at 09:47, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> > The first "Also ignore if NO INHERIT and we weren't told that that's
> > safe." is duplicated,
> > also it's in the wrong place?
> > The second one is fine.

> Hi! Indeed. Looks like an oversight from ca87c41. I think we can
> safely remove one of those, presumably the first one.

+1. Also there is an extra blank line after the NO INHERIT check. I
think we can remove it while we're here.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2025-03-28 10:27:20 Re: psql \dh: List High-Level (Root) Tables and Indexes
Previous Message Евгений Горбанев 2025-03-28 10:12:37 Re: Assert failure in base_yyparse