Re: duplicated comments on get_relation_constraints

On Fri, 28 Mar 2025 at 09:47, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> hi.
>
> in plancat.c, function: get_relation_constraints
>
> ```
> for (i = 0; i < num_check; i++)
> {
> Node *cexpr;
> /*
> * If this constraint hasn't been fully validated yet, we must
> * ignore it here. Also ignore if NO INHERIT and we weren't told
> * that that's safe.
> */
> if (!constr->check[i].ccvalid)
> continue;
>
> /*
> * NOT ENFORCED constraints are always marked as invalid, which
> * should have been ignored.
> */
> Assert(constr->check[i].ccenforced);
>
> /*
> * Also ignore if NO INHERIT and we weren't told that that's safe.
> */
> if (constr->check[i].ccnoinherit && !include_noinherit)
> continue;
> }
> ``
>
> The first "Also ignore if NO INHERIT and we weren't told that that's
> safe." is duplicated,
> also it's in the wrong place?
> The second one is fine.
>
>

Hi! Indeed. Looks like an oversight from ca87c41. I think we can
safely remove one of those, presumably the first one.

--
Best regards,
Kirill Reshke