| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: duplicated comments on get_relation_constraints |
| Date: | 2025-03-28 16:38:36 |
| Message-ID: | CALdSSPg0g74msX901ERexFf7ENo+=1GLvbyHmUQtB1UtFrtExg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 28 Mar 2025 at 15:19, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> On Fri, Mar 28, 2025 at 4:53 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> > On Fri, 28 Mar 2025 at 09:47, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> > > The first "Also ignore if NO INHERIT and we weren't told that that's
> > > safe." is duplicated,
> > > also it's in the wrong place?
> > > The second one is fine.
>
> > Hi! Indeed. Looks like an oversight from ca87c41. I think we can
> > safely remove one of those, presumably the first one.
>
> +1. Also there is an extra blank line after the NO INHERIT check. I
> think we can remove it while we're here.
>
> Thanks
> Richard
Sure. PFA attached, if needed
--
Best regards,
Kirill Reshke
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fixups-remove-empty-line-fix-oversight-of-ca87c41.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-03-28 16:42:48 | Re: Proposal: Progressive explain |
| Previous Message | Peter Eisentraut | 2025-03-28 16:32:47 | Re: On non-Windows, hard depend on uselocale(3) |