From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
---|---|
To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: duplicated comments on get_relation_constraints |
Date: | 2025-04-02 02:39:38 |
Message-ID: | CAMbWs49GzbzTa_Qon1XxcB9BaApXYX_bZf=D+bZ_GVY2K9aVmw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 29, 2025 at 1:38 AM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> On Fri, 28 Mar 2025 at 15:19, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > On Fri, Mar 28, 2025 at 4:53 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> > > On Fri, 28 Mar 2025 at 09:47, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> > > > The first "Also ignore if NO INHERIT and we weren't told that that's
> > > > safe." is duplicated,
> > > > also it's in the wrong place?
> > > > The second one is fine.
> > > Hi! Indeed. Looks like an oversight from ca87c41. I think we can
> > > safely remove one of those, presumably the first one.
> > +1. Also there is an extra blank line after the NO INHERIT check. I
> > think we can remove it while we're here.
> Sure. PFA attached, if needed
The change looks good to me. I plan to push it soon, barring any
objections.
Thanks
Richard
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2025-04-02 03:21:44 | Re: Statistics Import and Export |
Previous Message | Robert Haas | 2025-04-02 02:24:25 | Re: Statistics Import and Export |