From: | Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated) |
Date: | 2020-08-03 14:30:54 |
Message-ID: | CAMa=N=MW9skJiVY=EZa+Px+L3Ti_gcOgKJz4O==AF-UPaUsvPQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hello,
Please find the attached patch -
Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation
Phone: +91-9741705709
On Mon, Aug 3, 2020 at 12:56 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Yogesh
>
> Instead of declaring global variables, I would suggest declaring them as a
> class variable (constants). Make the changes and resend the patch
>
> On Mon, Aug 3, 2020 at 10:40 AM Yogesh Mahajan <
> yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find patch which fixes 15+ issues related to rule -
>> 1.String literals should not be duplicated
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachment | Content-Type | Size |
---|---|---|
SonarQubeFix12_v2.patch | application/octet-stream | 36.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-08-04 06:40:17 | Re: [pgAdmin4][Patch] - SonarQube Fixes |
Previous Message | Aditya Toshniwal | 2020-08-03 09:50:32 | Re: WIP: SQL Formatter |