Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Yogesh Mahajan <yogesh(dot)mahajan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)
Date: 2020-08-03 07:26:05
Message-ID: CANxoLDdDrg5bZ0qgfyUgt_dbkkYqzp+vPzFFCP7=fetCvwg0eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Yogesh

Instead of declaring global variables, I would suggest declaring them as a
class variable (constants). Make the changes and resend the patch

On Mon, Aug 3, 2020 at 10:40 AM Yogesh Mahajan <
yogesh(dot)mahajan(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find patch which fixes 15+ issues related to rule -
> 1.String literals should not be duplicated
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-08-03 07:48:21 pgAdmin 4 commit: Corrected the syntax as per jinja standards. refs #56
Previous Message Aditya Toshniwal 2020-08-03 07:16:26 [pgAdmin][SonarQube] Fixes for 13 rules.