| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch] - SonarQube Fixes |
| Date: | 2020-08-04 06:40:17 |
| Message-ID: | CANxoLDf93wWrt8W94wVhtz1mzFJJe2Hb8UNDPmL+maxwnpNcrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Khushboo
As per offline discussion, multiple developers declaring the constant for
the same string and error messages. To avoid that only one developer should
work on this task.
Suggestions:
- We should have a common class for Constants (which are not module
specific).
- For module specific constants we should not declare them as Global
variables if possible declare them as the Class variable.
- For common error messages(if any) we can define functions in
PGChildNodeView.
Please incorporate the changes send by Yogesh.
On Mon, Aug 3, 2020 at 1:36 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch to fix the sonarqube code smells having the
> rule "String literals should not be duplicated".
>
> Thanks,
> Khushboo
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-08-04 10:21:09 | pgAdmin 4 commit: Ensure that the Dictionaries drop-down shows all the |
| Previous Message | Yogesh Mahajan | 2020-08-03 14:30:54 | Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated) |