Re: [pgAdmin4] [PATCH] Simplify Server's python setup

From: Jan Alexander Steffens <jan(dot)steffens(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4] [PATCH] Simplify Server's python setup
Date: 2017-01-28 01:00:01
Message-ID: CAMQ-g0dxWFV_xOByCgVdyRSG2vywMjJ98H93=Rtxf+9bHOnDJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Jan 27, 2017 at 5:56 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Fri, Jan 27, 2017 at 1:37 PM, Jan Alexander Steffens
> <jan(dot)steffens(at)gmail(dot)com> wrote:
> > I did mean Py_SetPath, not PySys_SetPath.
>
> Ah, OK - it wouldn't compile with that (Python 2 :-/ ) so I assumed it
> was a typo.
>
> > Unfortunately, after checking
> > again it turns out this is Python 3 only. Python 2 has no means of
> changing
> > the module_search_path from outside. So, there it definitely needs a
> > restart. :-(
>
> Yeah :-(. How does the attached patch look to you?
>

Looks good to me, thanks! I've tested both selecting a venv and the
venv-beside-runtime.

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-01-30 05:09:19 [pgAdmin4][Patch]: RM2047 - Allow user to move panel over the menu bar
Previous Message Neel Patel 2017-01-27 19:06:13 [pgAdmin4][Patch]: RM#2015 - Trigger issues