[pgAdmin4][Patch]: RM#2015 - Trigger issues

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: RM#2015 - Trigger issues
Date: 2017-01-27 19:06:13
Message-ID: CACCA4P3x5RyH1LirKvu7Y=_NAcCd_3DB0WZ_p_kJZqOgMmnQhA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find attached patch file for the fix of RM#2015.

Below additional issues are fixed along with description provided in RM.

- When user update any of the parameter - trigger gets disappear from
browser tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline
edb-spl" trigger function, even though "Row Trigger" is enabled.
- SQL was not generated properly when user change 'Row Trigger', Fires
and events.
- Edit Mode - Fires and Events should be allowed to edit for "inline
edb-spl" function mentioned with Code in description.
- Edit Mode - For trigger, if user edit parameters like Fires, Events,
Code, Row trigger etc. then new OID is getting generated so we should fetch
and return new OID in response rather then old trigger OID.

Do review it and let us know for comments.

Thanks,
Neel Patel

Attachment Content-Type Size
RM_2015_v1.patch application/octet-stream 7.8 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Jan Alexander Steffens 2017-01-28 01:00:01 Re: [pgAdmin4] [PATCH] Simplify Server's python setup
Previous Message George Gelashvili 2017-01-27 17:18:18 [Patch] Bypass recovery state for Greenplum