From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: RM#2015 - Trigger issues |
Date: | 2017-01-30 13:06:11 |
Message-ID: | CA+OCxowQjHGCX-iWf4Ygembec0vV0noA+F9dVNzTEn_Wm_YqCg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Jan 27, 2017 at 7:06 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find attached patch file for the fix of RM#2015.
>
> Below additional issues are fixed along with description provided in RM.
>
> When user update any of the parameter - trigger gets disappear from browser
> tree. To make it visible user has to do refresh.
> Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl"
> trigger function, even though "Row Trigger" is enabled.
> SQL was not generated properly when user change 'Row Trigger', Fires and
> events.
> Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl"
> function mentioned with Code in description.
> Edit Mode - For trigger, if user edit parameters like Fires, Events, Code,
> Row trigger etc. then new OID is getting generated so we should fetch and
> return new OID in response rather then old trigger OID.
>
> Do review it and let us know for comments.
>
> Thanks,
> Neel Patel
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-01-30 14:02:04 | pgAdmin 4 commit: Ensure dialogues cannot be moved under the navbar. Fi |
Previous Message | Dave Page | 2017-01-30 13:05:19 | pgAdmin 4 commit: Resolve various trigger issues. Fixes #2015 |