From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin 4 commit: Resolve various trigger issues. Fixes #2015 |
Date: | 2017-01-30 13:05:19 |
Message-ID: | E1cYBe3-0008Lj-KU@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Resolve various trigger issues. Fixes #2015
- Allow changing of row/statement flag
- When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" trigger function, even though "Row Trigger" is enabled.
- SQL was not generated properly when user change 'Row Trigger', Fires and events.
- Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" function mentioned with Code in description.
- Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, Row trigger etc. then new OID is getting generated so we should fetch and return new OID in response rather then old trigger OID.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e8f0cf6d94a5bb40975645ea55213aa75337451c
Author: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Modified Files
--------------
.../templates/trigger/sql/9.1_plus/update.sql | 23 +++++++++++++++-------
.../databases/schemas/tables/triggers/__init__.py | 13 ++++++++++--
.../triggers/templates/trigger/js/trigger.js | 19 ++++++++++++++++++
3 files changed, 46 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-01-30 13:06:11 | Re: [pgAdmin4][Patch]: RM#2015 - Trigger issues |
Previous Message | Dave Page | 2017-01-30 12:50:25 | Re: [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties |