Re: [pgAdmin4] [PATCH] Simplify Server's python setup

On Fri, Jan 27, 2017 at 1:37 PM, Jan Alexander Steffens
<jan(dot)steffens(at)gmail(dot)com> wrote:
> On Fri, Jan 27, 2017 at 12:04 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> On Thu, Jan 26, 2017 at 7:22 PM, Jan Alexander Steffens
>> <jan(dot)steffens(at)gmail(dot)com> wrote:
>> > Looking through the cpython code, Py_SetPath(NULL) clears the calculated
>> > module search path again. Try calling this before the Py_Initialize.
>>
>> Unfortunately that just crashes:
>
>
>>
>> 1 org.python.python 0x000000010daec349 PySys_SetPath + 24
>
>
> I did mean Py_SetPath, not PySys_SetPath.

Ah, OK - it wouldn't compile with that (Python 2 :-/ ) so I assumed it
was a typo.

> Unfortunately, after checking
> again it turns out this is Python 3 only. Python 2 has no means of changing
> the module_search_path from outside. So, there it definitely needs a
> restart. :-(

Yeah :-(. How does the attached patch look to you?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company