From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors |
Date: | 2019-08-12 06:51:40 |
Message-ID: | CAM9w-_ni=P2=sUFC8tav1Xr63NKQ0v34TGvZ9yoJKQ7wKeX+bQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
This seemed to have disabled the drag drop feature. Attached is a minor fix
to reenable it.
On Fri, Aug 2, 2019 at 3:59 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Thanks, patch applied.
>
> On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the issue where dragging a selected text in
>> SQL editor throws console errors and does not move the text.
>>
>> As an improvement, the patch also fixes a potential issue where importing
>> jquery.event.drag will override drag events and will break drag and drop
>> feature. Currently jquery.event.drag is not imported. Changes are made to
>> use vanilla addEventListener instead of jquery on() to attach drag related
>> events to avoid conflict.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
RM4552.part2.patch | application/octet-stream | 601 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2019-08-12 07:03:33 | Re: [GSoC] Query History Upgrade |
Previous Message | Akshay Joshi | 2019-08-12 06:17:07 | Re: [pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error |