From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors |
Date: | 2019-08-02 10:29:16 |
Message-ID: | CA+OCxoxazBG15YnF8_6kZM1DdnsoRLTzo7Rvo4GE3UaeGJKfWA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to fix the issue where dragging a selected text in
> SQL editor throws console errors and does not move the text.
>
> As an improvement, the patch also fixes a potential issue where importing
> jquery.event.drag will override drag events and will break drag and drop
> feature. Currently jquery.event.drag is not imported. Changes are made to
> use vanilla addEventListener instead of jquery on() to attach drag related
> events to avoid conflict.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2019-08-02 13:05:12 | pgAdmin 4 commit: Add various make targets for auditing the Python and |
Previous Message | Dave Page | 2019-08-02 10:29:00 | pgAdmin 4 commit: Fix some errors thrown on the JS console when draggin |