| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors |
| Date: | 2019-08-02 05:25:00 |
| Message-ID: | CAM9w-_=3L1AbnTm8+Mi5M2Z1_QK04a+2SVADQmy5HQVnWaXwSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
Attached is the patch to fix the issue where dragging a selected text in
SQL editor throws console errors and does not move the text.
As an improvement, the patch also fixes a potential issue where importing
jquery.event.drag will override drag events and will break drag and drop
feature. Currently jquery.event.drag is not imported. Changes are made to
use vanilla addEventListener instead of jquery on() to attach drag related
events to avoid conflict.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
| Attachment | Content-Type | Size |
|---|---|---|
| RM4552.patch | application/octet-stream | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-08-02 06:24:31 | Re: [RM#4546] Add RE-SQL tests for Column node |
| Previous Message | Yosry Muhammad | 2019-08-02 04:38:21 | Ensure View Data mode fetches next rows on scrolling through results when appropriate. Fixes #4536. |