Re: [RM#4546] Add RE-SQL tests for Column node

Hi Murtuza

Following test cases are missing:

- Primary Key column.
- Variable options.
- Precision and Collation.
- Identity column with 'GENERATED AS BY DEFAULT'.
- ALTER column with identity values like CYCLE, minimum, maximum etc..
instead of updating comments in such test cases.
- Generated expression should use existing columns if possible like
(col1 * col2).

Apart from that can you please look into *RM #4500 *which seems minor
issue. Please send separate patch for both.

On Thu, Aug 1, 2019 at 5:36 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi All
>
> I'll review this patch and give my review comments.
>
> On Wed, Jul 31, 2019 at 4:10 PM Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA patch to add RE-SQL tests for Column node.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*