From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors |
Date: | 2019-08-12 07:42:25 |
Message-ID: | CANxoLDe2aoM5b9EXHg9vQ-1G5VFb5KQrFHg_ejzC=5TSNqRYtg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks patch applied.
On Mon, Aug 12, 2019 at 12:22 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> This seemed to have disabled the drag drop feature. Attached is a minor
> fix to reenable it.
>
> On Fri, Aug 2, 2019 at 3:59 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks, patch applied.
>>
>> On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix the issue where dragging a selected text in
>>> SQL editor throws console errors and does not move the text.
>>>
>>> As an improvement, the patch also fixes a potential issue where
>>> importing jquery.event.drag will override drag events and will break drag
>>> and drop feature. Currently jquery.event.drag is not imported. Changes are
>>> made to use vanilla addEventListener instead of jquery on() to attach drag
>>> related events to avoid conflict.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Yosry Muhammad | 2019-08-12 08:30:37 | Re: [GSoC] Query History Upgrade |
Previous Message | Akshay Joshi | 2019-08-12 07:42:05 | pgAdmin 4 commit: Fix issue in drag drop feature. It's regression of RM |