| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin][RM3582] Can not add JSON-string as comments on objects |
| Date: | 2019-04-12 07:49:09 |
| Message-ID: | CAM9w-_n5OYc6aXQeC1MpBgsTxsMWMCoar6nirtZve=C4i_k0aA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
Attached is to fix issue where adding JSON like comments on objects were
considered as JSON instead of string, because of which the comments were
altered at few places.
I have checked all the objects mentioned on
https://www.postgresql.org/docs/current/sql-comment.html in pgAdmin and
fixed wherever required.
Please note, this patch also fixed RM4121 (a word change).
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
| Attachment | Content-Type | Size |
|---|---|---|
| RM3582.patch | application/octet-stream | 24.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-04-12 09:38:33 | pgAdmin 4 commit: 1) Ensure that JSON strings as comments should be add |
| Previous Message | Dave Page | 2019-04-11 16:15:27 | Re: [pgAdmin4] Add API tests for Download CSV route in query tool |