| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM3582] Can not add JSON-string as comments on objects |
| Date: | 2019-04-12 09:38:57 |
| Message-ID: | CANxoLDchSrG5WAvHGgw0SU_GRWs=pikjf6eoh=1=O0NkJ1cEBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks patch applied.
On Fri, Apr 12, 2019 at 1:19 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is to fix issue where adding JSON like comments on objects were
> considered as JSON instead of string, because of which the comments were
> altered at few places.
>
> I have checked all the objects mentioned on
> https://www.postgresql.org/docs/current/sql-comment.html in pgAdmin and
> fixed wherever required.
>
> Please note, this patch also fixed RM4121 (a word change).
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-04-15 11:12:49 | pgAdmin 4 commit: Ensure we create a DMG file that's compatible with ma |
| Previous Message | Akshay Joshi | 2019-04-12 09:38:33 | pgAdmin 4 commit: 1) Ensure that JSON strings as comments should be add |