Re: [pgAdmin4] Add API tests for Download CSV route in query tool

Thanks - committed!

On Thu, Apr 11, 2019 at 3:30 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> PFA updated patch with suggested changes.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Thu, Apr 11, 2019 at 6:27 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Apr 11, 2019 at 12:21 PM Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to add API tests for Download CSV route in query tool.
>>> > python runtests.py --pkg tools.sqleditor.tests --exclude feature_tests
>>>
>>
>> Nice addition, but can you modify it so it doesn't spit the "table
>> doesn't exist" error out to the terminal? We're trying to clean up the test
>> output at the moment.
>>
>> Oh, and it should be this_table_does_not_exist (without the trailing s
>> :-) )
>>
>> runTest
>> (pgadmin.tools.sqleditor.tests.test_download_csv_query_tool.TestDownloadCSV)
>> Download csv URL with wrong query ... 2019-04-11 13:54:38,710: ERROR
>> flask.app: failed to execute query ((with server cursor) for the server
>> #4 - CONN:3783391 (query-id: 5309318):
>> error message:ERROR: relation "this_table_does_not_exists" does not exist
>> LINE 1: SELECT * FROM this_table_does_not_exists
>> ^
>>
>> ok
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company